-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source maps are in production build #348
Comments
They are intentionally left in this project because it is just a starter project, and it is so far from an actual deployable production environment. Obviously, on a real production system, they would be disabled. Perhaps some documentation to that effect might help. |
Actually I noticed that as well this morning. @hamczu would be great if you can share how you would see the css compiler pipeline for a production enviroment |
@erikras Would you mind share some thoughts about what should be done before a project based on this starter kit be deployed in production server? Some help in this way would be great. This running my first project using redux+react... |
The source maps is about it. And really, almost no one is going to see your production source maps because browsers don't download them by default. I've certainly never gone to a competitor's website with source maps turned on to glean insights or steal code, but as a general practice, they should be disabled. Obviously you'd need an actual auth mechanism. I don't really have a list of todos. |
I wasn't thinking about a todo list. It would be really nice if users share some tips and some pieces of advice regarding production deployment. Anyway...thanks for your excellent work on this project! |
@mclouvem +1 |
@mclouvem here are some problems that need to be addressed for a production deployment:
I'm still working on bringing my app based on this starter kit into production, so this probably isn't the full list :) |
@krukid Could you post an update/guide on your recommendations when you go thru all these steps that you have listed? I am going to hit that point soon and it'd be great to learn from your experience with productionizing this starter kit. |
@krukid That would be very useful to me as well! |
And to me as well. Thanks a lot |
I would remove them because main-[hash].js.map is around 4MB. And because of many other obvious reasons.
The text was updated successfully, but these errors were encountered: