-
-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Math.round issues #288
Labels
Comments
Addressed by es-shims/es6-shim@90c803f |
Sorry, that was in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
see https://twitter.com/BrendanEich/status/360832908514181122
Math.round(0.5 - Number.EPSILON / 4)
should be equal to0
Math.round((2 / Number.EPSILON + 1) / 2 + 1)
should be equal to(2 / Number.EPSILON + 1) / 2 + 1
Math.round(2 / Number.EPSILON)
should be equal to2 / Number.EPSILON
The ES5 spec - http://es5.github.io/#x15.8.2.15 - says, that
Math.round
"Returns the Number value that is closest to x and is equal to a mathematical integer", butNote 2
says nothing aboutNote 2
was fixed in ES6 - https://people.mozilla.org/~jorendorff/es6-draft.html#sec-math.roundSome browsers have good implementaions (FF 35, Chrome ?):
https://bugzilla.mozilla.org/show_bug.cgi?id=622348
https://bugzilla.mozilla.org/show_bug.cgi?id=1000606
But IE 11, Opera 12, Safari are buggy here.
I think, the implementation may look like this:
The text was updated successfully, but these errors were encountered: