Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyTorch Profiler to track performance #129

Closed
4 tasks
gomezzz opened this issue Aug 20, 2021 · 3 comments
Closed
4 tasks

Add PyTorch Profiler to track performance #129

gomezzz opened this issue Aug 20, 2021 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gomezzz
Copy link
Collaborator

gomezzz commented Aug 20, 2021

Feature

Desired Behavior / Functionality

Until now we have used cprofile to investigate performance of torchquad. However, especially for GPUs it may be interesting to start investigating with the new PyTorch profiler. Especially, as it has recently received some upgrades.

What Needs to Be Done

  • Set up things so that profiling with PyTorch profiler is easily doable
  • Profile!
  • Feel free to sum up your conclusions as to what optimization targets might be from this.
  • (optionally) add a notebook or some code to run a performance analysis of torchquad using the profiler.
@gomezzz gomezzz added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 20, 2021
@gomezzz
Copy link
Collaborator Author

gomezzz commented Apr 12, 2022

@FHof Do you think this issue still makes sense? Otherwise, I would close it :)

@FHof
Copy link
Collaborator

FHof commented Apr 13, 2022

I think it only makes sense if you want to have the profiling code in this repository.
The profiling and benchmarking code which I have used are all in that folder of my fork: https://github.com/FHof/torchquad/tree/fritz/autoray/benchmarking_and_profiling
(Here's a copy of it in case the above link stopped working: benchmarking_and_profiling.zip)
The profiling code is in do_profile.py and a generated output for JAX, TensorFlow and PyTorch can be viewed in TensorBoard.
Example output for the profilers can be seen at FHof#13 and in my thesis.

@gomezzz
Copy link
Collaborator Author

gomezzz commented Apr 14, 2022

Perfect thanks! I will close this for now then.

@gomezzz gomezzz closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants