Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.4.0 #172

Closed
19 tasks done
gomezzz opened this issue Apr 21, 2023 · 8 comments
Closed
19 tasks done

Release 0.4.0 #172

gomezzz opened this issue Apr 21, 2023 · 8 comments
Assignees
Labels

Comments

@gomezzz
Copy link
Collaborator

gomezzz commented Apr 21, 2023

Feature

Changelog

to be written during release process

What Needs to Be Done (chronologically)

  • Create PR from main -> develop to incorporate hotfixes / documentation changes.
  • In case of merge conflicts create PR to fix them which is then merged into main / fix on GitHub but make sure to let it create a new branch for the changes.
  • Review the PR
  • Create PR to merge from current develop into release branch
  • Write Changelog in PR and request review
  • Review the PR (if OK - merge, but DO NOT delete the branch)
  • Minimize packages in requirements.txt and conda-forge submission. Update packages in setup.py
  • Check unit tests -> Check all tests pass and there are tests for all important features (go to cmder, activate TQ, go to tests folder, type "pytest" and run)
  • Check documentation -> Check presence of documentation for all features by locally building the docs on the release
  • Change version number in setup.py and docs (under conf.py)
  • Trigger the Upload Python Package to testpypi GitHub Action (https://github.com/esa/torchquad/actions/workflows/deploy_to_test_pypi.yml) on the release branch (need to be logged in)
  • Test the build on testpypi (with pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple torchquad)
  • Finalize release on the release branch
  • Create PR: release → main , release -> develop
  • PR Reviews
  • Merge release back into main, and develop
  • Create Release on GitHub from the last commit (the one reviewed in the PR) reviewed
  • Upload to PyPI
  • Update on conda following https://conda-forge.org/docs/maintainer/updating_pkgs.html
@gomezzz gomezzz self-assigned this Apr 21, 2023
@gomezzz
Copy link
Collaborator Author

gomezzz commented Apr 21, 2023

@ilan-gold do you remember, were there any things we meant to include before the next release? :) Once ready, I would start / go through the above process in the near future to bring your additions to the conda / pypi version. ✌️

@ilan-gold
Copy link
Collaborator

Yes @gomezzz I will clean this up and make the PR today. Then we can start the process.

@gomezzz
Copy link
Collaborator Author

gomezzz commented May 11, 2023

Open TODOs:

@ilan-gold
Copy link
Collaborator

Adding docs now for that.

@gomezzz
Copy link
Collaborator Author

gomezzz commented May 17, 2023

Unfortunately tests are currently failing on GPU, see #178 , this will need to be fixed first. Will look into it in the coming weeks when I find a second :)

@gomezzz
Copy link
Collaborator Author

gomezzz commented Jun 15, 2023

v0.4.0 is now on pip

waiting for conda to detect the new version, will then update the recipe over on https://github.com/conda-forge/torchquad-feedstock ✌️ :)

@ilan-gold
Copy link
Collaborator

Woooooo! @gomezzz it's been a great journey :) here's to more!

@gomezzz
Copy link
Collaborator Author

gomezzz commented Jun 19, 2023

Likewise! @ilan-gold :) 🍾 Happy to be working on this with you :)

@gomezzz gomezzz closed this as completed Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants