Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Readthedocs PR building #39

Open
chrisjsewell opened this issue Jan 27, 2023 · 4 comments
Open

Add Readthedocs PR building #39

chrisjsewell opened this issue Jan 27, 2023 · 4 comments

Comments

@chrisjsewell
Copy link
Contributor

FYI @ekouts you can get RTD to test the build of documentation for PRs: https://docs.readthedocs.io/en/stable/pull-requests.html#preview-documentation-from-pull-requests

Just log in and toggle the "build pull request" button, e.g.:

image

@chrisjsewell
Copy link
Contributor Author

Note in the .readthedocs.yml, I would also suggest eventually adding, although at the moment this fails (lots of warnings regarding the docstings)

sphinx:
    fail_on_warning: true

@ekouts
Copy link
Collaborator

ekouts commented Jan 27, 2023

Thanks! I didn't know about it :) I enabled it and I do see the builds in RTD but it doesn't appear in the PR, I am not sure if it has to do with my permissions in the organization

@chrisjsewell
Copy link
Contributor Author

Hmm, yeh I remember having some similar issue on one organisation, perhaps try having a look at the webhook and updating it 🤷 :

image

@ekouts
Copy link
Collaborator

ekouts commented Jan 30, 2023

Hey, tried that but my problem is Build status is not being reported to your VCS provider and I think the issue is that the eth-cscs organization hasn't granted access to the RTD OAuth app. I have requested the administrators of the org to enable it, but this may take some discussion/time. For now, unfortunately I have to check manually in my rtd account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants