Skip to content

Commit 061f365

Browse files
noerogkurtisvg
authored andcommitted
address review comments, fix failing test
1 parent b2e1e90 commit 061f365

File tree

1 file changed

+3
-29
lines changed

1 file changed

+3
-29
lines changed

healthcare/api-client/v1/hl7v2/hl7v2_stores_test.py

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ def crud_hl7v2_store_id():
140140
retry_on_exception=retry_if_server_exception)
141141
def clean_up():
142142
try:
143-
hl7v2_stores.delete_hl7v2_store_id(
143+
hl7v2_stores.delete_hl7v2_store(
144144
project_id, cloud_region, dataset_id, hl7v2_store_id)
145145
except HttpError as err:
146146
# The API returns 403 when the HL7v2 store doesn't exist.
@@ -187,38 +187,19 @@ def test_CRUD_hl7v2_store(test_dataset, crud_hl7v2_store_id, capsys):
187187
assert 'Deleted HL7v2 store' in out
188188

189189

190-
def test_patch_hl7v2_store(test_dataset, capsys):
191-
hl7v2_stores.create_hl7v2_store(
192-
project_id,
193-
cloud_region,
194-
dataset_id,
195-
hl7v2_store_id)
196-
190+
def test_patch_hl7v2_store(test_dataset, test_hl7v2_store, capsys):
197191
hl7v2_stores.patch_hl7v2_store(
198192
project_id,
199193
cloud_region,
200194
dataset_id,
201195
hl7v2_store_id)
202196

203-
# Clean up
204-
hl7v2_stores.delete_hl7v2_store(
205-
project_id,
206-
cloud_region,
207-
dataset_id,
208-
hl7v2_store_id)
209-
210197
out, _ = capsys.readouterr()
211198

212199
assert 'Patched HL7v2 store' in out
213200

214201

215-
def test_get_set_hl7v2_store_iam_policy(test_dataset, capsys):
216-
hl7v2_stores.create_hl7v2_store(
217-
project_id,
218-
cloud_region,
219-
dataset_id,
220-
hl7v2_store_id)
221-
202+
def test_get_set_hl7v2_store_iam_policy(test_dataset, test_hl7v2_store, capsys):
222203
get_response = hl7v2_stores.get_hl7v2_store_iam_policy(
223204
project_id,
224205
cloud_region,
@@ -233,13 +214,6 @@ def test_get_set_hl7v2_store_iam_policy(test_dataset, capsys):
233214
'serviceAccount:[email protected]',
234215
'roles/viewer')
235216

236-
# Clean up
237-
hl7v2_stores.delete_hl7v2_store(
238-
project_id,
239-
cloud_region,
240-
dataset_id,
241-
hl7v2_store_id)
242-
243217
out, _ = capsys.readouterr()
244218

245219
assert 'etag' in get_response

0 commit comments

Comments
 (0)