A few questions regarding contribution #2372
mattjennings
started this conversation in
General
Replies: 2 comments 10 replies
-
@mattjennings These are great questions, sorry for the struggles
|
Beta Was this translation helpful? Give feedback.
6 replies
-
Oh it looks like chrome isn't packaged for arm64, that might explain a few
things...
https://askubuntu.com/questions/1383789/install-chrome-on-ubuntu-debian-with-arm64
We might be able to get away with chromium, I don't think we leverage
anything truly chrome specific.
…On Wed, Jun 29, 2022 at 9:29 AM Matt Jennings ***@***.***> wrote:
That's what I had thought too, but without specifying platform it couldn't
install google-chrome-stable
<puppeteer/puppeteer#7752> while building the
container. However I did also try specifying platform: linux/amd64 and
that built too, but still has the same error when running the tests.
This seems to be a known puppeteer issue
<puppeteer/puppeteer#7746>, but the suggested
fixes of adding --single-process and --disable-gpu to the puppeteer
config in karma (the latter of which was already there) didn't work. I'll
keep digging, but I might just resign to a Linux VM at this point :P
—
Reply to this email directly, view it on GitHub
<#2372 (reply in thread)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEVNZ7MKGDQRX4WEZENNQTVRRMVXANCNFSM52EB45DQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I have a few questions relating to contribution and the state of the repo, as I've started working away at #1548.
Some of these may warrant their own issues, but for now just dumping it all here for discussion!
npm run test
). I'm using a Macbook with M1 so I have a feeling that's why, as these are passing on CI. Do you know if anyone has tried running them on M1 before? Majority of them are WebGL errors, like this:Is prettier enforced by anything? I ran
npm run prettier
and it updated 233 files. It also then causednpm run lint
to fail (conflicting rules)The
.vscode/settings.json
eslint config needs an update, as the eslint vscode extension pops this up every character I type 😅I'm happy to make individual PRs to address at least the linting side of things. As for the tests, that one seems rather complicated if it is M1 related 😞
Beta Was this translation helpful? Give feedback.
All reactions