You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some latent issues found during review from #1237:
prjxray/xjson.py is poorly named. Should be renamed to something akin to sort_complex_data
prjxray.xjson.extract_numbers won't handle mixed formatting well. Example given was extract_numbers("A100") > extract_numbers("100B"), which generates error:
In [1]: (100, 't') > ('t', 100)
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
<ipython-input-1-d06ca7865f0c> in <module>()
----> 1 (100, 't') > ('t', 100)
TypeError: '>' not supported between instances of 'int' and 'str'
prjxray.xjson.extract_numbers and prjxray.xjson.sort could use some more unit tests, above example is a good one.
The text was updated successfully, but these errors were encountered:
Some latent issues found during review from #1237:
prjxray/xjson.py
is poorly named. Should be renamed to something akin tosort_complex_data
prjxray.xjson.extract_numbers
won't handle mixed formatting well. Example given wasextract_numbers("A100") > extract_numbers("100B")
, which generates error:prjxray.xjson.extract_numbers
andprjxray.xjson.sort
could use some more unit tests, above example is a good one.The text was updated successfully, but these errors were encountered: