-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module based library ( support for Java 9+ ) #1996
Comments
@ankeetj : Our client has been compatible with JDK 11 since v4.1.2 |
I'm using 4.6.4 version of kubernetes-client and there is no module-info.class there. |
A quick workaround for this would be to add an Automatic-Module-Name directive to the MANIFEST.MF file in your published jars. It doesn't require any other Java 9 specifics, nor does your code have to behave like a module. However, it does provide a stable module name for anybody that does want to use your client in a modular application. Without it, a modular application importing your library on the modulepath gets a name generated from the filename of the jar, which is obviously not a good thing. To do this, you need to do two things
|
This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions! |
Are there any short or long term plans on adding support for java modules? |
Actually, we tried moving to java modules but it seemed quite painful as it required some of the dependencies (like sundrio for builder generation) to move to modules too. Are you blocked due to this issue? |
We have a workaround where we re-package the kubernetes-client packages in 1 jar, so certainly no blocker. |
Now that #4464 / #4460 has been tackled, we should be able to complete this issue. #2110 should now be closed or recreated from scratch (@rohanKanojia). |
Hello from (almost) 2025. What is the status of this issue? |
Well, we just updated the Java baseline to 11 on version 7.0.0. Also, PRs welcome ;) |
I'm using Java 11 and trying to create a lightweight JRE . Is there a new version for kubernetes-client which uses modules ? It will make uptake very easy in java 9 + .
The text was updated successfully, but these errors were encountered: