Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pytx][large project] Migrate pytx CLI to use the same storage interfaces as HMA (if possible) #1754

Open
11 tasks
Dcallies opened this issue Feb 5, 2025 · 0 comments
Labels
code quality Issues that make the code better but do not noticeably change the surface or core algorithms. python-threatexchange Items related to the threatexchange python tool / library

Comments

@Dcallies
Copy link
Contributor

Dcallies commented Feb 5, 2025

This is a multistep project, and it might be too difficult to do except for by the original goofballs who worked on the original libraries (mostly @Dcallies).

The first pass at storage interfaces lives in https://github.com/facebook/ThreatExchange/blob/main/python-threatexchange/threatexchange/cli/cli_config.py

We originally though we would be able to reuse the interface for HMA, but we quickly realized we could not, and so ended up with a separate implementation here: https://github.com/facebook/ThreatExchange/blob/main/hasher-matcher-actioner/src/OpenMediaMatch/storage/interface.py

Now looking back at the CLI, it would be nice to unify these two stacks.

Thus, we want to:

  1. Migrate the HMA storage interfaces to the pytx library
  2. Delete the HMA copy and use pytx as the source of truth
  3. Duplicate the existing CLI implementation to follow the same interface
  4. Replace all the calls in the existing cli code to use interfaced versions
@Dcallies Dcallies added code quality Issues that make the code better but do not noticeably change the surface or core algorithms. python-threatexchange Items related to the threatexchange python tool / library labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Issues that make the code better but do not noticeably change the surface or core algorithms. python-threatexchange Items related to the threatexchange python tool / library
Projects
None yet
Development

No branches or pull requests

1 participant