Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use repr(source) in Pipeline.__repr__ #264

Closed
mthrok opened this issue Nov 6, 2024 · 0 comments · Fixed by #267
Closed

Do not use repr(source) in Pipeline.__repr__ #264

mthrok opened this issue Nov 6, 2024 · 0 comments · Fixed by #267

Comments

@mthrok
Copy link
Collaborator

mthrok commented Nov 6, 2024

When source is list of data that contains byte string, calling repr(source) can take forever to generate the string representation of source, and it's wasteful. So it should be avoided.

Instead check if the source has __name__ attribute and use it if that's available. Otherwise use type().__name__.

@mthrok mthrok mentioned this issue Nov 7, 2024
@mthrok mthrok closed this as completed in 23c4151 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant