Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout with retry hangs with Failsafe 2.4.4 #348

Closed
darkjh opened this issue Nov 14, 2022 · 1 comment
Closed

Timeout with retry hangs with Failsafe 2.4.4 #348

darkjh opened this issue Nov 14, 2022 · 1 comment
Labels

Comments

@darkjh
Copy link

darkjh commented Nov 14, 2022

I'm having a problem with Failsafe 2.4.4 when composing retry and timeout policy like Failsafe.with(retryPolicy, timeoutPolicy).getStageAsync(...).
This snippet should reproduce the issue https://gist.github.com/darkjh/fd84c945474dd163a342017e40a9e375

Basically the issue is that when having multiple attempts, the first attempt got timed out correctly, but subsequent retries are scheduled but never started and no progress would be made.

I also tested the same snippet in Failsafe 3.2.4 and everything works, each retry attempts are timed out and the future completes. I'm aware of different past discussion around timeout policy but even with 2.4.4 version I would expect the retries get executed and completed as timeout but not hanging.

@jhalterman
Copy link
Member

jhalterman commented Nov 14, 2022

I'm not sure when I'll get to look into this, or if it will be possible to fix without a lot of the other changes that went into 3.x. For now, I would assume that there won't be another 2.x release, and that upgrading to 3.x would be recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants