Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigir_2022_BISER Code Review #29

Open
Hamedloghmani opened this issue Dec 1, 2022 · 1 comment
Open

sigir_2022_BISER Code Review #29

Hamedloghmani opened this issue Dec 1, 2022 · 1 comment
Assignees

Comments

@Hamedloghmani
Copy link
Member

This issue is just a log file of my progress in reviewing the sigir_2022_BISER repo.

After running the given examples for the first time. My initial thoughts is that the code is not really user friendly and understandable on first attempts. Lacks a lot of comments and even some of the comments are in Korean I guess. There were some points that was kind of surprising since this repo is the official codebase for SIGIR 2022 accepted paper.

  1. Inconsistency in the material for creating an environment.

  2. Using Tensorflow 1.* in a code developed in 2021-22.

  3. Lack of proper comments and explanation in this code.

  4. Some small issues like importing a library and not using it.

A snap shot of the first run:
BISER first run

@Hamedloghmani Hamedloghmani self-assigned this Dec 1, 2022
@hosseinfani
Copy link
Member

@Hamedloghmani
You should not expect a nice and readable codebase for a research work. This is just to showcase the feasibility not for the production line. As long as it runs and the results can be reproduced, it's more than enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants