Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of assert() : move to always-enabled DIAG_ASSERT ? #72

Open
fenugrec opened this issue Feb 24, 2021 · 0 comments
Open

use of assert() : move to always-enabled DIAG_ASSERT ? #72

fenugrec opened this issue Feb 24, 2021 · 0 comments

Comments

@fenugrec
Copy link
Owner

Follow-up to discussion in PR #71 , as well as issue #68 .

There's already some use of assert() throughout the codebase, but there could be more - for instance more argument validation (such as calling diag_l0_send with len == 0), etc.

To have those always-enabled (regardless of NDEBUG), it could be a better idea to use a new macro or wrapper func with our own assert implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant