Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d3fc/datagrid packages point to nonexistent "types" location #2824

Closed
brianblakely opened this issue Nov 4, 2024 · 1 comment
Closed

d3fc/datagrid packages point to nonexistent "types" location #2824

brianblakely opened this issue Nov 4, 2024 · 1 comment
Labels
bug Concrete, reproducible bugs

Comments

@brianblakely
Copy link
Contributor

"types": "dist/esm/types/index.d.ts",

The types property above points to a declaration file which is not created. I would file a simple PR to change, but there are two extant D files, "index.d.ts" and "types.d.ts" and I am not sure which is preferable.

@texodus texodus added the bug Concrete, reproducible bugs label Nov 27, 2024
@timkpaine timkpaine changed the title d3fc package points to nonexistent "types" location d3fc/datagrid packages point to nonexistent "types" location Dec 1, 2024
@finos finos deleted a comment from arslan-charyyev Feb 2, 2025
@texodus
Copy link
Member

texodus commented Feb 2, 2025

Please use the Issue template! I am not a TypeScript expert and we have working TypeScript examples in the repo.

I spent some time experimenting with this and I've found two cases that create warning in a no-config TS project:

  1. Trying to capture the export symbol e.g. import * as dg from "@finos/perspective-viewer-datagrid". This is bugged as you describe - but there are no exports in these packages so you should be able to work around this by removing the dg binding.
  2. Importing a sub-path file directly e.g. import "@finos/perspective-viewer-datagrid/dist/esm/perspective-viewer-datagrid.js".

I have updated the types exports for these packages in #2910, this will only impact #1 (but you should likely not bind this symbol anyway ..). If there are additional failures, please create a new Issue with details.

@texodus texodus closed this as completed Feb 2, 2025
@texodus texodus mentioned this issue Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

No branches or pull requests

2 participants