Skip to content

Incorrect releases assets #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bayardar opened this issue May 21, 2025 · 1 comment
Open

Incorrect releases assets #625

bayardar opened this issue May 21, 2025 · 1 comment

Comments

@bayardar
Copy link

The v1.0.0 rbuilder binary is built for x86_64-unknown-linux-gnu architecture, while the latest v1.1.0 release binary is built for aarch64-unknown-linux-gnu.

I think all the binaries should be uploaded in the release assets, this seems the idea considering what is present in the github workflow file for the build-binary step : https://github.com/flashbots/rbuilder/blob/v1.1.0/.github/workflows/release.yaml#L104-L108

@ngotchac
Copy link

The issue is that you upload an artifact w/ the target triple in the name, but it only gives this name to the zip file, not the inner content. If you look at your latest build: https://github.com/flashbots/rbuilder/actions/runs/14754212164/job/41418895724 the https://github.com/flashbots/rbuilder/actions/runs/14754212164/artifacts/3037392117 zip file contains only rbuilder binary. So by fetching artifacts for the matrix of target triple, they overwrite each others.

The fix would simply be to rename the binaries before uploading them as artifacts, to include the target triple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants