-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support writing Avro containers asynchronously #140
Comments
Would a PR that adds support for |
Thanks for being willing to contribute, @kendru! I am not thrilled by the perspective of tying this library to any of the async runtimes, as there isn't truly any standard atm (although tokio seems to be the most mature among them). Even if we want to add support for it, it would be under a cargo feature. @alexbiehl is also the only one who asked for such a feature, so I can't really tell that there is much of request for it either. As for now, perhaps we could offer the possibility to the users of implementing the Writer interface, so they can implement it for their runtime of choice? What do you people think? |
@poros I completely understand not wanting to tie this library to a specific async runtime, and I would be happy to try implementing tokio's |
I am only a bit worried that we will need to keep maintaining it in a fast-changing ecosystem when, at the end, it isn't a core component of a serde library. @kendru : what do you think about the |
Have you any ETA about async? @kendru have you any fork or patch for async? How to permit the usage of tokio and async_std? |
Currently
avro_rs::Writer
expects the underlying writer to implementstd::io::Write
which makes it unsuitable for use in streaming environments with futures/async_std/tokio.I know the ecosystem is a little scattered but it would be great if avro_rs supported one of the asynchronous write interfaces like
tokio::io::AsyncWrite
orasync_std::io::Write
.The text was updated successfully, but these errors were encountered: