Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Doesn't work with the flavors on the very_good create app template #466

Open
Tracked by #379
aalex opened this issue Mar 20, 2023 · 2 comments
Open
Tracked by #379

Comments

@aalex
Copy link

aalex commented Mar 20, 2023

ℹ️ Info

Version: 0.12.0

💬 Description

I am trying to set up some app icons, but I don’t see the right icons. We started from a very_good create app template, and then added some icons with flutter_launcher_icons, but the default icons from the very_good app template were not replaced by the ones generated by flutter_launcher_icons. How can we fix this? Here is a minimal prototype that reproduces the bug, and a but ticket that describes it, including all the technical details: artpluscodeinc/proto_very_good_flavor_icons#1

📜 Pubspec.yaml

name: proto_very_good_flavor_icons
description: Prototype that allows to create custom application icons according to the flavor.
version: 1.0.0+1
publish_to: none

environment:
  sdk: ">=2.19.0 <3.0.0"

dependencies:
  bloc: ^8.1.1
  flutter:
    sdk: flutter
  flutter_bloc: ^8.1.2
  flutter_localizations:
    sdk: flutter
  intl: ^0.17.0

dev_dependencies:
  bloc_test: ^9.1.1
  flutter_launcher_icons: ^0.12.0
  flutter_test:
    sdk: flutter
  mocktail: ^0.3.0
  very_good_analysis: ^4.0.0

flutter:
  uses-material-design: true
  generate: true
@lucasdidur
Copy link

This happens because of the name of the files inside the Contents.json that is linked to the files that already come in the project.

Just delete the images and the Contents.json file and generate again.

This was referenced Apr 12, 2023
@MarkOSullivan94
Copy link
Collaborator

I've spent some time looking into why this is occurring for the Android app at least. It looks like the issue is to do with ic_launcher.xml within the mipmap-anydpi-v26 for both main and whatever flavor you're trying to run.

I setup a basic quick test with flutter_launcher_icons and found that if I delete both of these then ic_launcher.png which is generated by flutter_launcher_icons is used instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants