Skip to content

Commit 73f2a19

Browse files
committed
Fixes issue #69 : Enhanced feedback to Selection/Deselection of CheckBox
1 parent 6b7a152 commit 73f2a19

File tree

2 files changed

+39
-9
lines changed

2 files changed

+39
-9
lines changed

src/index.css

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,3 +50,17 @@ li {
5050
list-style-type: disc !important;
5151
margin-left: 1rem;
5252
}
53+
.selectedLabel {
54+
font-weight: 400;
55+
color: #333333;
56+
}
57+
58+
.unselectedLabel {
59+
font-weight: 300;
60+
color: #666666;
61+
}
62+
63+
.selectedLabel, .unselectedLabel {
64+
transition: color 0.3s ease-in-out, font-weight 0.3s ease-in-out;
65+
}
66+

src/scripts/main.js

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -82,19 +82,25 @@ function handleEndingDateChange() {
8282
}
8383
function handleLastWeekContributionChange() {
8484
var value = lastWeekContributionElement.checked;
85+
var labelElement = document.querySelector("label[for='lastWeekContribution']");
86+
8587
if (value) {
86-
startingDateElement.disabled = true;
87-
endingDateElement.disabled = true;
88-
endingDateElement.value = getToday();
89-
startingDateElement.value = getLastWeek();
90-
handleEndingDateChange();
91-
handleStartingDateChange();
88+
startingDateElement.disabled = true;
89+
endingDateElement.disabled = true;
90+
endingDateElement.value = getToday();
91+
startingDateElement.value = getLastWeek();
92+
labelElement.classList.add("selectedLabel");
93+
labelElement.classList.remove("unselectedLabel");
9294
} else {
93-
startingDateElement.disabled = false;
94-
endingDateElement.disabled = false;
95+
startingDateElement.disabled = false;
96+
endingDateElement.disabled = false;
97+
labelElement.classList.add("unselectedLabel");
98+
labelElement.classList.remove("selectedLabel");
9599
}
100+
96101
chrome.storage.local.set({ lastWeekContribution: value });
97102
}
103+
98104
function getLastWeek() {
99105
var today = new Date();
100106
var noDays_to_goback = gsoc == 0 ? 7 : 1;
@@ -135,9 +141,19 @@ function handleProjectNameChange() {
135141
}
136142
function handleOpenLabelChange() {
137143
var value = showOpenLabelElement.checked;
144+
var labelElement = document.querySelector("label[for='showOpenLabel']");
145+
146+
if (value) {
147+
labelElement.classList.add("selectedLabel");
148+
labelElement.classList.remove("unselectedLabel");
149+
} else {
150+
labelElement.classList.add("unselectedLabel");
151+
labelElement.classList.remove("selectedLabel");
152+
}
153+
138154
chrome.storage.local.set({ showOpenLabel: value });
139-
chrome.storage.local.set({ showClosedLabel: value });
140155
}
156+
141157
function handleUserReasonChange() {
142158
var value = userReasonElement.value;
143159
chrome.storage.local.set({ userReason: value });

0 commit comments

Comments
 (0)