Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Have the option to resize cover available all the time #79

Open
jrbastien opened this issue Oct 17, 2012 · 3 comments
Open

Idea: Have the option to resize cover available all the time #79

jrbastien opened this issue Oct 17, 2012 · 3 comments

Comments

@jrbastien
Copy link
Contributor

jrbastien commented Oct 17, 2012

This is really just an enhancement but it would be cool to be able to resize covers on the fly instead of having to go to the plugin preferences.

This would be helpful if the "genre" filter requested in #77 is implemented. When you only have a few albums for a specific genre (or even a search), you could simply use the slider to enlarge the size as it best fits the screen.
f
The same slider that is in the options screen could be moved to the bottom of the cover pane.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@hellpe
Copy link

hellpe commented Oct 18, 2012

Or you could use Ctrl+mousewheel, like in Nautilus and Firefox.

@asermax
Copy link
Contributor

asermax commented Oct 19, 2012

The reason for what that behavior isn't implemented yet is explained on my last post on issue #13.
Basically, there's a memory leak on the iconview model (or we might be using it wrong?) when recreating the covers' pixbufs after resizing.
I haven't find a solution for this yet, and I think this enhancement shouldn't be implemented before fixing that problem first.

@fossfreedom
Copy link
Owner

Note - just had a quick relook at this. Under pygobject 3.12 & python 3 this memory leak issue is not observed.

Thus could look at this again with maybe a scale button. Need to have a closer look at the documentation to see what Gtk does/does not offer here.

EDIT: the only relevant GTK widget at gtk 3.10 is a ScaleButton. It is naff - not very well defined and works oddly. Think a PopOver widget would be better here but that is GTK 3.12.

Need to find example applications who have used "sliders" of some-sort in a popup. For the moment - retask this back to wishlist until either someone lets me know of a useful slider popup that I can grab or I "accidently" find something myself...

EDIT: quodlibet may have something to investigate:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants