Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api_docs): remove link to v3 docs from latest #5153

Merged
merged 4 commits into from
Feb 27, 2025
Merged

fix(api_docs): remove link to v3 docs from latest #5153

merged 4 commits into from
Feb 27, 2025
+6 −5

Conversation

elisa-a-v
Copy link
Contributor

Closes #5121

@elisa-a-v elisa-a-v requested a review from mlissner February 26, 2025 23:20
@mlissner
Copy link
Member

There's a flag you can send to any template to say index=False, that sets the meta HTML tag. Could you use that here?

@mlissner
Copy link
Member

(I think it's in base.html.)

@mlissner mlissner assigned elisa-a-v and unassigned mlissner Feb 27, 2025
@elisa-a-v
Merge branch 'main' into 5121-remove-link-to-v3-docs
0f35a12
@elisa-a-v
refactor(api_docs): replace html tags with view flag
78e0308 
Instead of explicitly adding the meta tag in each
template for old versions of the docs, we now use
the view flag 'private=True' for old ones.
@elisa-a-v
Copy link
Contributor Author

There's a flag you can send to any template to say index=False, that sets the meta HTML tag. Could you use that here?

Oooh that's much better, thanks! I changed it now :)

@elisa-a-v elisa-a-v assigned mlissner and unassigned elisa-a-v Feb 27, 2025
@mlissner mlissner merged commit c2d6c3e into main Feb 27, 2025
15 checks passed
@mlissner mlissner deleted the 5121-remove-link-to-v3-docs branch February 27, 2025 22:00
@mlissner
Copy link
Member

Kind of javascript-ish! Great, thank you and merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlissner mlissner Awaiting requested review from mlissner

Assignees

@mlissner mlissner

Labels
None yet
Projects
Sprint (Web Team)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove link to v3 docs at top of v4 docs
2 participants
@elisa-a-v @mlissner