Skip to content

Commit 66a9e48

Browse files
committed
Fix unnecessary nil check around range
1 parent d85ee5e commit 66a9e48

File tree

1 file changed

+9
-16
lines changed

1 file changed

+9
-16
lines changed

webhook.go

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -250,10 +250,9 @@ func hookHandler(w http.ResponseWriter, r *http.Request) {
250250
}
251251

252252
// handle hook
253-
if errors := matchedHook.ParseJSONParameters(&headers, &query, &payload); errors != nil {
254-
for _, err := range errors {
255-
log.Printf("[%s] error parsing JSON parameters: %s\n", rid, err)
256-
}
253+
errors := matchedHook.ParseJSONParameters(&headers, &query, &payload)
254+
for _, err := range errors {
255+
log.Printf("[%s] error parsing JSON parameters: %s\n", rid, err)
257256
}
258257

259258
var ok bool
@@ -341,27 +340,21 @@ func handleHook(h *hook.Hook, rid string, headers, query, payload *map[string]in
341340
cmd.Dir = h.CommandWorkingDirectory
342341

343342
cmd.Args, errors = h.ExtractCommandArguments(headers, query, payload)
344-
if errors != nil {
345-
for _, err := range errors {
346-
log.Printf("[%s] error extracting command arguments: %s\n", rid, err)
347-
}
343+
for _, err := range errors {
344+
log.Printf("[%s] error extracting command arguments: %s\n", rid, err)
348345
}
349346

350347
var envs []string
351348
envs, errors = h.ExtractCommandArgumentsForEnv(headers, query, payload)
352349

353-
if errors != nil {
354-
for _, err := range errors {
355-
log.Printf("[%s] error extracting command arguments for environment: %s\n", rid, err)
356-
}
350+
for _, err := range errors {
351+
log.Printf("[%s] error extracting command arguments for environment: %s\n", rid, err)
357352
}
358353

359354
files, errors := h.ExtractCommandArgumentsForFile(headers, query, payload)
360355

361-
if errors != nil {
362-
for _, err := range errors {
363-
log.Printf("[%s] error extracting command arguments for file: %s\n", rid, err)
364-
}
356+
for _, err := range errors {
357+
log.Printf("[%s] error extracting command arguments for file: %s\n", rid, err)
365358
}
366359

367360
for i := range files {

0 commit comments

Comments
 (0)