Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests, remove those not applicable to the GO version of biolink-api. fixes #17 #15

Open
wants to merge 70 commits into
base: master
Choose a base branch
from

Conversation

sierra-moxon
Copy link
Member

@sierra-moxon sierra-moxon commented Aug 25, 2021

Where applicable and failing, replace with succeeding versions of upstream biolink-API.
Add GitHub actions
Add working Dockerfile (with changes to support accessing the API via a docker container)

@sierra-moxon sierra-moxon changed the title fix tests, remove those not applicable to the GO version of biolink-api fix tests, remove those not applicable to the GO version of biolink-api. Aug 25, 2021
@sierra-moxon sierra-moxon requested a review from lpalbou August 25, 2021 00:07
@sierra-moxon sierra-moxon changed the title fix tests, remove those not applicable to the GO version of biolink-api. fix tests, remove those not applicable to the GO version of biolink-api. fixes #17 Aug 25, 2021
@sierra-moxon
Copy link
Member Author

locally, the tests all pass:

50 scenarios passed, 0 failed, 0 skipped
196 steps passed, 0 failed, 0 skipped, 0 undefined
Took 0m20.250s```

@sierra-moxon
Copy link
Member Author

@sierra-moxon sierra-moxon removed the request for review from lpalbou August 25, 2021 18:14
@sierra-moxon
Copy link
Member Author

finally green! :) - I moved over to GitHub Actions for a few reasons:

  1. it seems like GitHub would like folks to migrate (Travis was at some point threatening to retire, in favor of actions, though it hasn't happened yet).
  2. actions are more common in the projects across BBOP.
  3. requirements installation was much faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant