Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should have a "minimum-stability" description at documentation? #1058

Open
marcosfreitas opened this issue May 19, 2020 · 3 comments
Open

Should have a "minimum-stability" description at documentation? #1058

marcosfreitas opened this issue May 19, 2020 · 3 comments

Comments

@marcosfreitas
Copy link

marcosfreitas commented May 19, 2020

So, In my very first install, my project has a "minimum-stability : stable" instruction into composer.json. It hurts the installation process of some (or all) dependencies, so I could not fix that changing to "dev" instead of "stable" and installing puli/composer-plugin, so I don't know what is the best approach here. Could anyone describe the necessary minimum-stability to use the Geocoder package and additional providers?

Bellow, it is my current composer.json dependencies:

{
    "name": "marcos/itcm-google-maps-interceptor-for-csv-importer",
    "type": "project",
    "require": {
        "geocoder-php/google-maps-provider": "^4.4",
        "php-http/guzzle6-adapter": "^2.0",
        "vlucas/phpdotenv": "^4.1"
    },
    "minimum-stability": "dev",
    "require-dev": {
        "symfony/var-dumper": "^5.0"
    }
}
@jbelien
Copy link
Member

jbelien commented May 19, 2020

Thanks for your feedback @marcosfreitas !

It should work with "minimum-stability": "stable", I'll check why it doesn't !

@marcosfreitas
Copy link
Author

marcosfreitas commented May 19, 2020

I removed "minimum-stability" instruction and added "php-http/message": "^1.8" and it worked. Why it's is necessary I don't know. geocoder-php/google-maps-provider failed to be instantiated without it but it is a dev dependency.

@mrelliot69

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants