Datahub: Add pagination for table component #1120

tkohr · 2025-02-17T15:42:12Z

Description

This PR introduces pagination to the table.component

Todos:

handle geo-table
pagination: layout and translate
storybook
tests

Screenshots

Quality Assurance Checklist

Commit history is devoid of any merge commits and readable to facilitate reviews
If new logic ⚙️ is introduced: unit tests were added
If new user stories 🤏 are introduced: E2E tests were added
If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
If breaking changes 🪚 are introduced: add the breaking change label
If bugs 🐞 are fixed: add the backport <release branch> label
The documentation website 📚 has received the love it deserves

github-actions · 2025-02-17T15:44:08Z

Affected libs: feature-dataviz,
Affected apps: datahub,

🚀 Build and deploy storybook and demo on GitHub Pages
📦 Build and push affected docker images

github-actions · 2025-02-19T16:30:56Z

📷 Screenshots are here!

jahow

Thank you!! that looks really good! I'll try this alongside with the PR from @AlitaBernachot and see if everything goes according to plan ;)

libs/ui/dataviz/src/lib/table/table.component.stories.ts

libs/ui/dataviz/src/lib/table/table.component.html

libs/ui/dataviz/src/lib/table/table.component.ts

AlitaBernachot · 2025-02-21T16:02:15Z

libs/ui/dataviz/src/lib/table/table.component.stories.ts

+// export const WithWfs: StoryObj<TableComponent> = {
+//   loaders: [
+//     async () => ({
+//       dataset: await openDataset(


Hello, small change, function signature has changed:

await openDataset( 'https://www.geo2france.fr/geoserver/cr_hdf/ows', 'wfs', { wfsFeatureType: 'accidento_hdf_L93', } ), `

coveralls · 2025-02-21T22:12:34Z

coverage: 85.618% (+1.2%) from 84.467%
when pulling 72239c9 on paginate-table-compoonent
into 77e75b4 on main.

and fix horizontal scroll

and keep loading state in table-view.component

… and use it in the geo-table-view.component

Also make the footer the same size as before

…data-view

As this is not supported by the Reader API

Also throw an error when trying to show the graph

making ViewChild wait for table

incase reader encounters an issue

independent of maxFeatureCount

libs/ui/dataviz/src/lib/data-table/data-table.component.ts

jahow

Everything's looking good to me now. Thanks for the involvement! these were quite big changes.
We might revisit some things related to the integration in the datahub as we get some usage feedback.

jahow reviewed Feb 19, 2025

View reviewed changes

libs/ui/dataviz/src/lib/table/table.component.stories.ts Outdated Show resolved Hide resolved

libs/ui/dataviz/src/lib/table/table.component.html Outdated Show resolved Hide resolved

libs/ui/dataviz/src/lib/table/table.component.html Show resolved Hide resolved

tkohr marked this pull request as ready for review February 20, 2025 16:14

jahow reviewed Feb 21, 2025

View reviewed changes

libs/ui/dataviz/src/lib/table/table.component.ts Outdated Show resolved Hide resolved

jahow mentioned this pull request Feb 21, 2025

[Datahub] Wfs pagination in data fetcher #1126

Merged

7 tasks

AlitaBernachot reviewed Feb 21, 2025

View reviewed changes

jahow force-pushed the paginate-table-compoonent branch from b404f14 to 4e531b2 Compare February 21, 2025 22:04

jahow force-pushed the paginate-table-compoonent branch 2 times, most recently from ad9f43e to cabd2ba Compare February 21, 2025 22:53

tkohr and others added 18 commits February 22, 2025 11:06

feat(table): implement data.source and pass reader to table

53fe72a

feat(table): add mat paginator

03397cd

feat(table): display 10 items per page

9acf9b6

and fix horizontal scroll

feat(table): impove css positioning

ee90676

and keep loading state in table-view.component

fix(storybook): pass data via a mock reader to table

2443309

feat(geo-table-view): change input to reader (WIP)

823b00e

feat(table): translate paginator labels

1a3565e

feat(table): recover displaying count info

09b2ad9

doc(i18n): add a comment on extraction issue

89c662d

test(table): rework tests

7d7d143

feat(geo-table-view): fix mapping and use GeojsonReader in story

1ba1be5

fix(table): update data when input changes

626ee8b

feat(table): keep a table-scroll.component without pagination for now…

4ef4450

… and use it in the geo-table-view.component

test(table-view): return observable with delay to test loading

7eee9c2

test(table): add e2e tests

ae33f40

feat(dataviz): add wfs and geojson stories for table

1e0a8e6

feat(ui): fix pagination in data table, improve storybook entry

c62f650

Also make the footer the same size as before

chore(ui): rename table to data-table

b60099b

jahow force-pushed the paginate-table-compoonent branch from cabd2ba to c358bc8 Compare February 22, 2025 10:28

jahow added 4 commits February 22, 2025 11:40

chore(dataviz): remove table-scroll component, use data-table in geo-…

ca14cc6

…data-view

chore(ui): enable wfs data-table storybook entry

6a5c9e2

feat(ui): add loading mask on data-table

27ade4d

feat(ui): disable clear sort on data-table

576ea1a

As this is not supported by the Reader API

jahow force-pushed the paginate-table-compoonent branch from c358bc8 to 576ea1a Compare February 22, 2025 10:47

jahow and others added 9 commits February 22, 2025 21:56

feat(ui): wait for properties to be read in data-table

bd7b787

feat(ui): do not load geom from WFS in data-table

b243497

Also throw an error when trying to show the graph

fix(data-table): fix sort

e191688

making ViewChild wait for table

test(data-table): fix unit tests

d7e693a

test(table-view): add test for undefined

9338653

feat(ui): add tests on data-table

d2a2be0

feat(data-fetcher): do not load all data to read WFS properties

48fe336

fix(wfs): fix type

f1db58d

test(data-table): test pagination

f9fade5

tkohr force-pushed the paginate-table-compoonent branch from cd2e7fa to f9fade5 Compare February 24, 2025 16:25

tkohr added 2 commits February 24, 2025 18:21

test(data-table): adapt fixtures for e2e tests

596f118

feat(data-table): add error handling

90ab2bb

incase reader encounters an issue

tkohr force-pushed the paginate-table-compoonent branch from dfc8637 to 90ab2bb Compare February 24, 2025 20:23

feat(record-data-preview): display table-view

1f6a35b

independent of maxFeatureCount

jahow reviewed Feb 25, 2025

View reviewed changes

libs/ui/dataviz/src/lib/data-table/data-table.component.ts Outdated Show resolved Hide resolved

tkohr and others added 2 commits February 25, 2025 09:33

feat(data-table): error should not be string

44e76a2

feat(util): return body alongside HTTP error in data-fetcher

c3d7b4d

jahow approved these changes Feb 25, 2025

View reviewed changes

chore(dh): reduce data preview height to avoid blank space

72239c9

tkohr force-pushed the paginate-table-compoonent branch from da3eb6d to 72239c9 Compare February 25, 2025 09:14

tkohr merged commit 97ab0d3 into main Feb 25, 2025
14 checks passed

tkohr deleted the paginate-table-compoonent branch February 25, 2025 09:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Datahub: Add pagination for table component #1120

Datahub: Add pagination for table component #1120

tkohr commented Feb 17, 2025 •

edited

Loading

github-actions bot commented Feb 17, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading

jahow left a comment

AlitaBernachot Feb 21, 2025

coveralls commented Feb 21, 2025 •

edited

Loading

jahow left a comment

Datahub: Add pagination for table component #1120

Datahub: Add pagination for table component #1120

Conversation

tkohr commented Feb 17, 2025 • edited Loading

Description

Screenshots

Quality Assurance Checklist

github-actions bot commented Feb 17, 2025 • edited Loading

github-actions bot commented Feb 19, 2025 • edited Loading

jahow left a comment

Choose a reason for hiding this comment

AlitaBernachot Feb 21, 2025

Choose a reason for hiding this comment

coveralls commented Feb 21, 2025 • edited Loading

jahow left a comment

Choose a reason for hiding this comment

tkohr commented Feb 17, 2025 •

edited

Loading

github-actions bot commented Feb 17, 2025 •

edited

Loading

github-actions bot commented Feb 19, 2025 •

edited

Loading

coveralls commented Feb 21, 2025 •

edited

Loading