Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: geoschem/netcdf-scripts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.2
Choose a base ref
...
head repository: geoschem/netcdf-scripts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 13 commits
  • 9 files changed
  • 1 contributor

Commits on Nov 29, 2022

  1. Add badges to README.md

    Added the license and latest-release badges
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    ec74628 View commit details
    Browse the repository at this point in the history
  2. Add .gitignore in root folder

    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    58476ee View commit details
    Browse the repository at this point in the history
  3. Added GitHub issue templates and pull request template

    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    9b5d779 View commit details
    Browse the repository at this point in the history
  4. Remove debug printout from isCoards

    scripts/isCoards:
    - Removed several debugging print statements that were leftover
      from diagnosing an previous bug.
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    92bfae0 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. isCoards now checks variables of type "int" (not allowed for GCHP)

    scripts/isCoards
    - Add code to parse the variable type from the ncdump output. If "int"
      is found, add a message to the @bad array that this is not allowed
      for GCHP.
    - Also trimmed trailing whitespace
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    6947f3d View commit details
    Browse the repository at this point in the history
  2. Updated CHANGELOG.md with the latest version information

    CHANGELOG.md
    - Removed old text carried over from GEOS-Chem repository
    - Added up-to-date version information
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    441edcb View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Exit isCoards if file not found; Point user to RTD docs (not GC wiki)

    scripts/isCoards
    - Exit the script if the input file is not found.  This can give
      erroneous output.
    - Update the "for more info" footer displayed on the screen to point
      to geos-chem.readthedocs.io instead of the GEOS-Chem wiki.  The wiki
      documentation has since been ported to RTD.
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    1d9211b View commit details
    Browse the repository at this point in the history
  2. Update footer display (add double quotes)

    scripts/isCoards
    - Added double quotes around"Work with netCDF files" and "Prepare
      COARDS-compliant netCDF files".  Cosmetic change.
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    5bcbf5a View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Add more checks for GCHP-compiliance to isCoards

    scripts/isCoards
    - Update GCHP-related messages with either "(requirement for GCHP)"
      or "(problem for GCHP)"
    - Check that dimension names have lowercase letters
    - Check that time:units does not have decimals
    - Check that there are 72 level centers/73 level edges (for GCHP)
    - Change "lev:positive" from an option to a requirement
    - Make sure that variables have dimensions in the proper order
    - Removed commented-out unused code
    - Add an ending separator line
    - Update comments
    - Trim trailing whitespace
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    108105e View commit details
    Browse the repository at this point in the history
  2. Bug fix: Rename temporary file in nc_chunk.pl

    scripts/nc_chunk.pl
    - Renamed the temporary file (used in the nccopy command to chunk the
      file) from "tmp.nc" to "tmp.$ncFile".  This will put "tmp." in front
      of whatever the input file name is called.
    - This resolves an issue where "tmp.nc" could not be chunked because
      the temporary filename was also called tmp.nc.
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8429297 View commit details
    Browse the repository at this point in the history
  3. Updated CHANGELOG.md for 0.1.4 release

    Added info about the modifications to isCoards and nc_chunk.pl
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    9c54fba View commit details
    Browse the repository at this point in the history
  4. Fixed bug in isCoard, in the check for decimals in "time:units"

    scripts/isCoards
    - Changed matching criteria "m/./" to "m/\./" where we check
      time:units for decimal points.  This had been returning false positives.
    
    CHANGELOG.md
    - Updated accordingly
    yantosca committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    7f38aad View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Updated the isCoards script to return the error status to the shell

    scripts/isCoards
    - Routine &analyzeResults returns the # of lines of the @bad array
      as the status, or 0 if no errors are found.
    - Use a "never-nest" style in routine "main", to move the error check
      to the top of the routine and avoid the else block
    - Consolidate the main() and exit($?) statements
    
    Signed-off-by: Bob Yantosca <[email protected]>
    yantosca committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    04a18df View commit details
    Browse the repository at this point in the history
Loading