Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include fees in the balance that left a wallet listed on transaction list #464

Open
stackingsaunter opened this issue Aug 12, 2024 · 7 comments
Labels
good first issue Good for newcomers

Comments

@stackingsaunter
Copy link
Contributor

Currently, they are only visible in details.

@stackingsaunter stackingsaunter added the good first issue Good for newcomers label Aug 12, 2024
@bumi
Copy link
Contributor

bumi commented Aug 12, 2024

do you really want that? more numbers? what will it tell people and which other tranasction lists do that?

@stackingsaunter
Copy link
Contributor Author

How is it more numbers? It's the same amount of numbers

Wallet that do that: Phoenix, Bitkey, Strike, Bitkit, Blink, Aqua

Wallets that don't do that: Muun, Blockstream Green, Umbrel

@rolznz
Copy link
Contributor

rolznz commented Aug 13, 2024

The title of this issue is weird, but this is what you mean, right?

Use the sum of the amount + fee for the value shown on entries in the transaction list

Then when you open the details you would see the amount + fee separated

@rolznz
Copy link
Contributor

rolznz commented Aug 13, 2024

@reneaaron brought up a good point - if we make this change it should be consistent across all Alby products (currently none are done this way)

@GBKS
Copy link

GBKS commented Sep 16, 2024

I agree with @rolznz. Show the total amount that left your wallet in the transaction list, and show the breakdown in the details (maybe also in a hover tool tip on desktop).

@stackingsaunter
Copy link
Contributor Author

Thanks @GBKS for your input, I also think this is best

@stackingsaunter
Copy link
Contributor Author

In that case I would adopt this in all our products, and we could start with Hub? @rolznz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants