Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency on names and words: Alby Hosted Balance -> Alby Shared Node Balance #633

Open
jpl-btc opened this issue Sep 9, 2024 · 6 comments

Comments

@jpl-btc
Copy link
Contributor

jpl-btc commented Sep 9, 2024

I've noticed some minor confusion regarding the term "Alby Hosted Balance." It's not a serious issue, but users seem to get a bit mixed up. Is there a specific reason why it's not called "Alby Shared Node Balance," as it is on the getalby.com web account?

If not, could we update the terminology to use the same name everywhere? This would make it easier for users to associate the terms consistently, especially when we address support inquiries related to misunderstandings or mismanagement.

I propose we change "Alby Hosted Balance" to "Alby Shared Node Balance" for consistency.

image

@jpl-btc
Copy link
Contributor Author

jpl-btc commented Sep 9, 2024

Also:
"Alby shared wallet" to "Alby Shared Node Balance" for consistency.
image

Actually, I don't mind if the final name is "Alby Shared Node Balance" or "Alby Shared Wallet" or "Alby Hosted Balance". What matters here is that it is the same name everywhere, so that the users with difficulties understands with clarity we are referring to the same Alby legacy wallet, where their funds from their legacy wallet were.

@rolznz
Copy link
Contributor

rolznz commented Sep 9, 2024

CC @itstomekk

@itstomekk
Copy link
Contributor

Great find!

I'm all for having one name for it, also don't mind which.
Getalby.com dashboard calls it 'shared wallet' as well.

One more option to consider is Alby legacy wallet?

@rolznz rolznz added this to the v1.9.0 milestone Sep 12, 2024
@rolznz
Copy link
Contributor

rolznz commented Nov 19, 2024

@jpl-btc @itstomekk would either of you like to try a PR for this one?

@rolznz rolznz modified the milestones: v1.11.0, v1.12.0 Nov 20, 2024
@rolznz rolznz modified the milestones: v1.12.0, v1.13.0 Dec 17, 2024
@itstomekk
Copy link
Contributor

You mean here?

image

@itstomekk
Copy link
Contributor

itstomekk commented Dec 18, 2024

PS I think the rest is fine. We are susnetting shared node so doesn't matter that much anymore... but maybe it should be under "lightning"?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants