delete dispatcher objs correctly

rogerwang · rogerwang · commit 0430bacf9465 · 2014-02-07T21:09:01.000+08:00
Fix crash on quit after reloadDev
diff --git a/src/api/dispatcher_host.cc b/src/api/dispatcher_host.cc
@@ -60,9 +60,8 @@ DispatcherHost::~DispatcherHost() {
   g_dispatcher_host_map.erase(render_view_host());
   std::set<int>::iterator it;
   for (it = objects_.begin(); it != objects_.end(); it++) {
-    if (Base* obj = GetApiObject(*it)) {
-      delete obj;
-    }
+    if (objects_registry_.Lookup(*it))
+      objects_registry_.Remove(*it);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -60,9 +60,8 @@ DispatcherHost::~DispatcherHost() {`
`60`	`60`	`g_dispatcher_host_map.erase(render_view_host());`
`61`	`61`	`std::set<int>::iterator it;`
`62`	`62`	`for (it = objects_.begin(); it != objects_.end(); it++) {`
`63`		`- if (Base* obj = GetApiObject(*it)) {`
`64`		`- delete obj;`
`65`		`- }`
	`63`	`+ if (objects_registry_.Lookup(*it))`
	`64`	`+ objects_registry_.Remove(*it);`
`66`	`65`	`}`
`67`	`66`	`}`
`68`	`67`