Skip to content

Commit 828cf8b

Browse files
committed
Merge pull request nwjs#1981 from libm/master
Include breakpad symbols in dist package on Win and Mac
2 parents 9501793 + 94b6fda commit 828cf8b

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

tools/package_binaries.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ def generate_target_nw(platform_name, arch, version):
117117
'libGLESv2.dll',
118118
'nw.exe',
119119
'nw.pak',
120-
'nw.exp',
121-
'nw.lib',
120+
# 'nw.exp',
121+
# 'nw.lib',
122122
# 'nwsnapshot.exe',
123123
'credits.html',
124124
]
@@ -165,7 +165,8 @@ def generate_target_symbols(platform_name, arch, version):
165165
target['input'] = ['nw.breakpad.' + arch]
166166
elif platform_name == 'win':
167167
target['compress'] = 'zip'
168-
target['input'] = ['nw.exe.pdb']
168+
# target['input'] = ['nw.exe.pdb']
169+
target['input'] = []
169170
elif platform_name == 'osx':
170171
target['compress'] = 'tar.gz'
171172
target['input'] = [
@@ -185,7 +186,9 @@ def generate_target_others(platform_name, arch, version):
185186
target['output'] = ''
186187
target['compress'] = None
187188
if platform_name == 'win':
188-
target['input'] = ['nw.exp', 'nw.lib']
189+
target['input'] = ['nw.exp', 'nw.lib', 'nw.sym.7z']
190+
elif platform_name == 'osx' :
191+
target['input'] = ['node-webkit.breakpad.tar.bz2']
189192
else:
190193
target['input'] = []
191194
return target
@@ -248,6 +251,8 @@ def make_packages(targets):
248251
# now let's do it
249252
os.mkdir(dist_dir)
250253
for t in targets:
254+
if len(t['input']) == 0:
255+
continue
251256
if t['compress'] == None:
252257
if t['output'] != '':
253258
os.mkdir(dist_dir + t['output'])

0 commit comments

Comments
 (0)