-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form Class is loading queries (too?) eagerly causing (unnecessary) performance bottleneck #3746
Comments
🐛 cache benchmark index on set getkirby/kirby#3746
Great performance gain as explained in issue. closes getkirby#3746
…ons. This does greatly improve performance when options are fetched. See issue for more information. closes getkirby#3746
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
dear bot. this issue has not been resolved. please keep it open. |
I think we should revisit what you wrote in "expected behavior": If we can find a way to resolve the options less often and only when they are needed, this will increase performance by a lot, no matter if a cache is used or not. |
We have started refactoring our blueprint and form classes. Would be best to tackle this, once that's done. |
Describe the bug
Form class loads data even if it may be never used. it dataset is very big this causes a hugh delay for on each request. This is a common scenario in both autoid and boost plugin and currently make adding pages beyond 20k index impossible within 30sec timeout.
kirby/src/Cms/PageActions.php
Line 459 in efe24a6
To Reproduce
create a lot of pages of template
human
create a collection that does return a site->index()
human
page programmatically.Expected behavior
the query should only be executed in context of api/kql/panel or when called explicitly in php.
Kirby Version
3.5.7 and 3.6.0-beta.1
The text was updated successfully, but these errors were encountered: