Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions issue in the pages section "Add" button #3828

Open
bvdputte opened this issue Oct 20, 2021 · 7 comments
Open

Permissions issue in the pages section "Add" button #3828

bvdputte opened this issue Oct 20, 2021 · 7 comments

Comments

@bvdputte
Copy link

Describe the bug
The add() method in a pages section only checks global pages create permission. The consquence is that the Add button is never shown if the role/editor does not have this permissions. Nonetheless, if a role/user has permissions to create a page (can be template specific) in that pages section, he should be able to Add it from the pages section.

More info about this in the forum: https://forum.getkirby.com/t/kirby-permissions-to-give-role-permissions-to-manage-content-of-1-blueprint-only/23716

Expected behavior
A user should be able to add a page to a pages section if he has permissions to generate that page, even when his global "pages create" permission is false.

Kirby Version
3.5.7.1

@afbora
Copy link
Member

afbora commented Oct 21, 2021

I think this issue can be fixed in 3.7.0 that includes refactored sections with fiber.

@bvdputte
Copy link
Author

@afbora , I've just checked with the latest branch of develop (3.7.0-rc1 and a few commits further), and I still can't make it work? Any chance to get this in the release please?

It's an annoying issue and it's blocking further development. Apparently there are other waiting for this as well (see forum link).

thx!

@afbora
Copy link
Member

afbora commented Jun 23, 2022

Unfortunately, this is not so easy to solve. A case that concerns the blueprint of both sections and pages. We even have a concept for it: https://discord.com/channels/525634039965679616/985503322259722321/986529133347631114

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. This is for us to prioritize issues that are still relevant to our community. It will be closed if no further activity occurs within the next 14 days. If this issue is still relevant to you, please leave a comment.

@github-actions github-actions bot added the type: stale 💤 Will be closed soon because there was no recent activity label Dec 21, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2023
@bvdputte
Copy link
Author

Another question about this popped up on the forum: https://forum.getkirby.com/t/remove-the-add-block-button-for-permissions/29017

@texnixe
Copy link
Member

texnixe commented Jul 11, 2023

I think we should reopen this...

@lukasbestle lukasbestle reopened this Jul 11, 2023
@lukasbestle lukasbestle removed the type: stale 💤 Will be closed soon because there was no recent activity label Jul 11, 2023
@lukasbestle
Copy link
Member

lukasbestle commented Jul 11, 2023

I reopened the issue because it was closed by our stale bot when we still had it configured to close issues even when they have become stale because of us, not because of the issue author. Because there is demand for a fix, we of course need to have an open issue.

Unfortunately I cannot promise a quick fix for this, but at least we won't forget about this then. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants