Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Table layout: page status flag missing #6866

Open
distantnative opened this issue Dec 15, 2024 · 3 comments
Open

[v5] Table layout: page status flag missing #6866

distantnative opened this issue Dec 15, 2024 · 3 comments
Labels
type: regression 🚨 Is a regression between versions
Milestone

Comments

@distantnative
Copy link
Member

https://sandbox.test/panel/pages/sections+pages?tab=table

Somehow the page status flag is missing in v5 vs v4:

Screenshot 2024-12-15 at 11 46 17
@distantnative distantnative added the type: regression 🚨 Is a regression between versions label Dec 15, 2024
@distantnative distantnative added this to the 5.0.0-beta.2 milestone Dec 15, 2024
@bastianallgeier
Copy link
Member

It looks like the refactoring for the new view buttons is the problem here, but it's weird. I have created a first quick fix. But I'm not sure about the solution https://github.com/getkirby/kirby/tree/v5/fix/flag-column

@distantnative
Copy link
Member Author

Why do you think this is related to the view buttons changes?

From what I can tell, in v5 k-flag-field-preview is simply not receiving any value, whereas in v4 it receives something like

{ "status": "listed", "disabled": false } 

@distantnative
Copy link
Member Author

Ahh found the source: k-pages-section. Because we refactored the k-item with a buttons slot, we are now adding the flag value as just one entry in the buttons array instead of as a separate flag key. But the table layout relied on this being under the flag key as the table layout isn't really supporting the buttons array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression 🚨 Is a regression between versions
Projects
None yet
Development

No branches or pull requests

2 participants