Incorrect message regarding location

[srujner]

ODK Collect version

2024.3.0 Beta 8

Android version

Android 14,15

Device used

Samsung Galaxy M23, Pixel 6a

Problem description

During regression testing, I came across a test in which there were several required fields to check. https://sd-odk.atlassian.net/browse/NODK-1333 And I happened to have Location disabled on my phone, but Precise Location was enabled which caused me confusion when I saw an error dialog that I need to turn on the Precise Location permission.

Steps to reproduce the problem

1. Scan QR code:
   

2. Turn off Location in device setting

3. Have Precise Location permission turn on for ODK Collect app

4. Click on any map icon

5. the dialog informing that Without the Precise Location permission Collect can't record your location.

Expected behavior

To be honest I'm not sure if this is an issue, but I wanted to discuss if there shouldn't be a different dialog when the whole Location is turned off.

Other information

XRecorder_15112024_102657.mp4

[seadowg]

That's weird! It looks like from the code we expect to get told that the permission is granted, and then we check if location services enabled at the device level (and show a message if not). I'm surprised that we end up being told that the permission is "denied". I think this is something we could improve, but it's not high priority.

[latin-panda]

Hi there,

I encountered this issue while using Collect for the first time in Android 14, which caused some confusion. I was checking the permissions, reopening the app, and troubleshooting, but it wasn’t until later that I realized my location was turned off 😅

A quick improvement, while waiting for an actual fix, could be to update the message to include something like, 'Make sure location is turned on.'