Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byte data arguments #42

Open
kvark opened this issue May 7, 2018 · 1 comment
Open

Byte data arguments #42

kvark opened this issue May 7, 2018 · 1 comment
Labels
question

Comments

@kvark
Copy link
Member

kvark commented May 7, 2018

We are currently not consistent w.r.t. receiving &[u8] versus bare pointer + size. The former is a safer API but requires the user (sometimes) to convert whatever they have to a slice of u8. The former is tricky, since our methods are not marked as unsafe...
@kvark kvark added the question label May 7, 2018
@fkaa
Copy link
Collaborator

fkaa commented May 9, 2018

Given that we already use &str rather than NSString everywhere I think we're past being a -sys crate, so slices are preferable IMO 👍

@grovesNL grovesNL mentioned this issue Mar 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @fkaa