dont-display-stack-ids #6071
Merged
dont-display-stack-ids #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
rust
Caleb-T-Owens
force-pushed
the
dont-display-stack-ids
branch
from
d0ecae6 to
6f85b93
Compare
Caleb-T-Owens
force-pushed
the
dont-display-stack-ids
branch
from
6f85b93 to
1dc0c65
Compare
Caleb-T-Owens
force-pushed
the
dont-display-stack-ids
branch
from
1dc0c65 to
e132eb7
Compare
Caleb-T-Owens
force-pushed
the
dont-display-stack-ids
branch
from
e132eb7 to
80d7700
Compare
Caleb-T-Owens
force-pushed
the
dont-display-stack-ids
branch
from
80d7700 to
30ee14f
Compare
I ummed and ahhed about this one, because you _could_ use the other API to get the same data, but this API has the built in filtering which the frontend makes use of mre efficiently, and where I need the data in the next commit, it makes much more sense to use this API that I'm modifying here.
I'm looking up the details from the sidebar entry (which should already be loaded) and using the virtualBranchReference if it's present, before falling back to the PR title or remote branch given name. I also made use of the Badge component for the local badge which lets us tidy up some CSS
Caleb-T-Owens
force-pushed
the
dont-display-stack-ids
branch
from
30ee14f to
9398836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BR https://cloud.gitbutler.com/caleb-owens/gitbutler-client/reviews/36ba5e35-7894-4324-b1dd-673259bad120