Refactor the stack_branches command - separating commit listing #7347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
rust
krlvi
changed the title
mtsgrd
force-pushed
the
add-stack-branch-commits-function
branch
from
7a0efcf to
82fd01d
Compare
mtsgrd
force-pushed
the
add-stack-branch-commits-function
branch
from
82fd01d to
d55e732
Compare
mtsgrd
force-pushed
the
add-stack-branch-commits-function
branch
from
d55e732 to
ebda07f
Compare
mtsgrd
force-pushed
the
add-stack-branch-commits-function
branch
from
ebda07f to
35fbec8
Compare
Closed
- stack/branch/commit selection now uses the URL
mtsgrd
force-pushed
the
add-stack-branch-commits-function
branch
from
35fbec8 to
0610359
Compare
mtsgrd
reviewed
Feb 24, 2025
| let ctx = CommandContext::open(&project, AppSettings::default())?; | ||
| let local_and_remote = | ||
| stack_branch_local_and_remote_commits(id.to_string(), name.to_string(), &ctx); | ||
| debug_print(local_and_remote)?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are as follows:
stack_branchesno longer includes commits. Furthermore the archived state is available via a boolean field onWorkspaceBranchstack_branch_local_and_remote_commitswhich provides the commits for a stacked branch which are in the workspace (ordered newest to oldest, just as in the previous API)stack_branch_upstream_only_commitswhich provides the commits for a stacked branch which are at the upstream only (ordered newest to oldest, as before)Semantically the two new APIs provide the exact same data that was previously returned as part of the
stack_branchesresponse.Note: Both of the two new APIs are currenly only appropriate for accessing the commits of a stack branch in the workspace as they consider the "next head" in the stack as the end of the graph walk.