Move files from PR folder to the Forge folder #7378
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Caleb-T-Owens
force-pushed
the
move-shit-about
branch
from
70292c9 to
86d5dfd
Compare
There are several thoughts to be had here. ## getPr.svelte.ts This is a file that helps with accessing the forge services, giving a simpler interface. - Should this be a more generic catch all `forgePreview.svelte.ts` as it is bridging the gap between services and svelte? - Should this live in the base of `forge/` or should there be a `forge/pr/` folder which groups PR related things? ## prContents.svelte.ts This file is tied strongly to the PrDetailsModal.svelte. - Should this live in a folder with that `PrDetailsModal.svelte` file - Should this be more library like? ## Conclusion...  There are lots of permutations, and I think for now, I'm content to just put them in the forge folder and visit these questions later as there are pros and cons with all of the options
Caleb-T-Owens
force-pushed
the
move-shit-about
branch
from
86d5dfd to
f1f849a
Compare
Caleb-T-Owens
force-pushed
the
move-shit-about
branch
from
f1f849a to
b759278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several thoughts to be had here.
getPr.svelte.ts
This is a file that helps with accessing the forge services, giving a simpler interface.
forgePreview.svelte.tsas it is bridging the gap between services and svelte?forge/or should there be aforge/pr/folder which groups PR related things?prContents.svelte.ts
This file is tied strongly to the PrDetailsModal.svelte.
PrDetailsModal.sveltefileConclusion...
There are lots of permutations, and I think for now, I'm content to just put them in the forge folder and visit these questions later as there are pros and cons with all of the options