Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: when updating references it's okay if an existing reference doesnt match the existing value #7379

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

krlvi
Copy link
Member

@krlvi krlvi commented Feb 24, 2025

This is allowed because previously we had code which would create a git reference when a stack is unapplied but then never update what it points to. A reference that is out of date in this case would prevent operations

Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 4:56pm
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 4:56pm

@github-actions github-actions bot added the rust Pull requests that update Rust code label Feb 24, 2025
…nt match the existing value

This is allowed because previously we had code which would create a git reference when a stack is unapplied but then never update what it points to. A reference that is out of date in this case would prevent operations
@krlvi krlvi force-pushed the update-stack-branch-reference-handling branch from cf08006 to 857fa80 Compare February 24, 2025 16:54
@krlvi krlvi merged commit 3c6a251 into master Feb 24, 2025
23 checks passed
@krlvi krlvi deleted the update-stack-branch-reference-handling branch February 24, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant