Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nokogiri gem update due to security #4644

Merged
merged 2 commits into from
Feb 25, 2025
Merged

fix: nokogiri gem update due to security #4644

merged 2 commits into from
Feb 25, 2025

Conversation

jmeridth
Copy link
Member

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@jmeridth jmeridth self-assigned this Feb 24, 2025
@Copilot Copilot bot review requested due to automatic review settings February 24, 2025 17:26
@jmeridth jmeridth requested a review from a team as a code owner February 24, 2025 17:26

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR addresses a security update by adding the nokogiri gem while reordering the github-pages gem declaration in the Gemfile.

  • Added the nokogiri gem at version "~> 1.18.3"
  • Moved the github-pages gem declaration to follow faraday-retry, possibly for clarity or dependency order

Reviewed Changes

File Description
Gemfile Added nokogiri gem and adjusted the ordering of gems

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

@jmeridth jmeridth added this pull request to the merge queue Feb 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 24, 2025
@kenyonj kenyonj added this pull request to the merge queue Feb 25, 2025
@kenyonj kenyonj removed this pull request from the merge queue due to a manual request Feb 25, 2025
@kenyonj kenyonj added this pull request to the merge queue Feb 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 25, 2025
@kenyonj kenyonj added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit 6643c11 Feb 25, 2025
8 checks passed
@kenyonj kenyonj deleted the jm_nokogiri branch February 25, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants