Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for assistance: mapping charsets #228

Open
shlomi-noach opened this issue Sep 9, 2016 · 0 comments
Open

Request for assistance: mapping charsets #228

shlomi-noach opened this issue Sep 9, 2016 · 0 comments

Comments

@shlomi-noach
Copy link
Contributor

Matter at hand: gh-ost's support for multiple charsets.

gh-ost works well out-of-the-box with utf8 and utf8mb4.

However for other character sets it needs to be told, explicitly, how to convert strings. For example, the latin1 character set is supported, and is converted via golang's charmap.Windows1252, see: https://github.com/github/gh-ost/blob/master/go/sql/encoding.go#L20

If anyone is willing to assist in mapping other MySQL charsets to golang Encoders, we're very grateful. Please PR the https://github.com/github/gh-ost/blob/master/go/sql/encoding.go file with additional charsets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant