Skip to content

task: audit and improve security related tests #11

Closed
@GrantBirki

Description

@GrantBirki

The tests related to the security sections of this project have many # TODO comments. We need to investigate if these tests can be implemented or if they are even still relevant. If they are not, they should be fully removed. If they are relevant, implement them. What is most important is that these tests are clean, maintainable, and test for various security edge cases, bugs, etc.

Also help to ensure the code related to security is DRY, I see that dangerous_classes is duplicated in a few places. This dangerous_classes array mirrors the one in Helpers. Consider extracting it into a shared constant to avoid duplication and ensure consistency

Main tasks:

  • Make sure security related tests are clear, maintainable, and concise
  • Make sure they are still robust and test many cases while being concise
  • Implement TODO comments if possible
  • Keep security related code DRY

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions