Skip to content

task: validate built-in hmac and fix tests #31

Closed
@GrantBirki

Description

@GrantBirki

The lib/hooks/plugins/auth/hmac.rb file has gotten quite large and unwieldy. Please check it out and ensure it follows ruby best practices, is clean and concise. Ensure that all logic related to timestamp parsing is clean and easily testable.

A lot of the logic related to timestamps has gotten quite messy. It should be evaluated to become more maintainable. Do not break any existing logic. Also cleanup the hmac tests to be more DRY and concise as well. They have gotten quite long.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions