Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Feedback #1

Open
chrisking opened this issue Mar 4, 2019 · 0 comments
Open

Initial Feedback #1

chrisking opened this issue Mar 4, 2019 · 0 comments

Comments

@chrisking
Copy link

This is a great project!

The following issues are things that might trip up people following the exercise. Also I'd love to see this make it to the regular AWS Samples repo for Forecast!

https://github.com/githubmg/favorita-forecast/blob/master/1.CreateSample.ipynb

  1. Please cover how you downloaded the data or provide a location where anyone could download it ( you are currently using a private bucket ).
  2. There's no reason to del the df at the end since the notebook concludes.
  3. Provide a specific link or description to go to the next notebook.

https://github.com/githubmg/favorita-forecast/blob/master/2.ExploreAndFormat.ipynb

  1. It should be 'behaves' not 'behave'
  2. You have a few plots, label and explain why they are there
  3. Again link to the next notebook

https://github.com/githubmg/favorita-forecast/blob/master/3.PredictWithAmazonForecast.ipynb

  1. point to next notebook

https://github.com/githubmg/favorita-forecast/blob/master/4.InferWithDeployedPredictor.ipynb

GREAT WORK!

Overall

Please add a readme to this to guide people in a bit more of a general format. Also could you make this a subfolder and create a PR to the AWS Forecast Samples repo: https://github.com/aws-samples/amazon-forecast-samples

This is truly great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant