Skip to content

Commit 81a9625

Browse files
committed
Removed all debug code, it now runs about as fast as the previous version, but with less memory, still slower than the brute force version though
1 parent a7892bc commit 81a9625

File tree

1 file changed

+3
-34
lines changed

1 file changed

+3
-34
lines changed

_delta_apply.c

+3-34
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ bool TSI_copy_stream_from_object(ToplevelStreamInfo* info)
132132
void TSI_replace_stream(ToplevelStreamInfo* info, const uchar* stream, uint streamlen)
133133
{
134134
assert(info->parent_object == 0);
135-
fprintf(stderr, "TSI_replace_stream\n");
136135

137136
uint ofs = (uint)(info->cstart - info->tds);
138137
if (info->tds){
@@ -211,8 +210,6 @@ inline
211210
void DC_encode_to(const DeltaChunk* dc, uchar** pout, uint ofs, uint size)
212211
{
213212
uchar* out = *pout;
214-
DC_print(dc, "DC_encode_to");
215-
fprintf(stderr, "DC_encode_to: ofs = %i, size = %i\n" , ofs, size);
216213
if (dc->data){
217214
*out++ = (uchar)size;
218215
memcpy(out, dc->data+ofs, size);
@@ -239,17 +236,6 @@ void DC_encode_to(const DeltaChunk* dc, uchar** pout, uint ofs, uint size)
239236
*op = i;
240237
}
241238

242-
#ifdef DEBUG
243-
DeltaChunk mdc;
244-
DC_init(&mdc, 0, 0, 0, NULL);
245-
next_delta_info(*pout, &mdc);
246-
assert(mdc.ts == size);
247-
if (mdc.data)
248-
assert(mdc.data);
249-
else
250-
assert(mdc.so == dc->so+ofs);
251-
#endif
252-
253239
*pout = out;
254240
}
255241

@@ -577,7 +563,6 @@ uint DIV_copy_slice_to(const DeltaInfoVector* src, uchar** dest, ull tofs, uint
577563
{
578564
assert(DIV_lbound(src) <= tofs);
579565
assert((tofs + size) <= DIV_info_rbound(src, DIV_last(src)));
580-
fprintf(stderr, "copy_slice: ofs = %i, size = %i\n", (int)tofs, size);
581566

582567
DeltaChunk dc;
583568
DC_init(&dc, 0, 0, 0, NULL);
@@ -647,7 +632,6 @@ bool DIV_connect_with_base(ToplevelStreamInfo* tsi, DeltaInfoVector* div)
647632
for (;data < dend;)
648633
{
649634
data = next_delta_info(data, &dc);
650-
DC_print(&dc, "count");
651635

652636
// Data chunks don't need processing
653637
if (dc.data){
@@ -681,8 +665,6 @@ bool DIV_connect_with_base(ToplevelStreamInfo* tsi, DeltaInfoVector* div)
681665
{
682666
ndata = next_delta_info(data, &dc);
683667

684-
DC_print(&dc, "slice");
685-
686668
// Data chunks don't need processing
687669
if (dc.data){
688670
// just copy it over
@@ -705,17 +687,6 @@ bool DIV_connect_with_base(ToplevelStreamInfo* tsi, DeltaInfoVector* div)
705687
assert(tsi->tds == dstream);
706688
tsi->num_chunks = num_chunks;
707689

708-
#ifdef DEBUG
709-
data = TSI_first(tsi);
710-
dend = TSI_end(tsi);
711-
712-
DC_init(&dc, 0, 0, 0, NULL);
713-
714-
while (data < dend){
715-
data = next_delta_info(data, &dc);
716-
DC_print(&dc, "debug");
717-
}
718-
#endif
719690

720691
return 1;
721692

@@ -760,8 +731,6 @@ PyObject* DCL_py_rbound(DeltaChunkList* self)
760731
static
761732
PyObject* DCL_apply(DeltaChunkList* self, PyObject* args)
762733
{
763-
fprintf(stderr, "DCL_apply\n");
764-
765734
PyObject* pybuf = 0;
766735
PyObject* writeproc = 0;
767736
if (!PyArg_ParseTuple(args, "OO", &pybuf, &writeproc)){
@@ -1056,16 +1025,16 @@ static PyObject* connect_deltas(PyObject *self, PyObject *dstreams)
10561025

10571026
#ifdef DEBUG
10581027
fprintf(stderr, "------------ Stream %i --------\n ", (int)dsi);
1059-
fprintf(stderr, "Before Connect: tdsinfo: num_chunks = %i, bytelen = %i, target_size = %i\n", (int)tdsinfo.num_chunks, (int)tdsinfo.tdslen, (int)tdsinfo.target_size);
1060-
fprintf(stderr, "div->num_chunks = %i, div->reserved_size = %i, div->bytelen=%i\n", (int)div.size, (int)div.reserved_size, (int)dlen);
1028+
fprintf(stderr, "Before Connect: tdsinfo: num_chunks = %i, bytelen = %i KiB, target_size = %i KiB\n", (int)tdsinfo.num_chunks, (int)tdsinfo.tdslen/1000, (int)tdsinfo.target_size/1000);
1029+
fprintf(stderr, "div->num_chunks = %i, div->reserved_size = %i, div->bytelen=%i KiB\n", (int)div.size, (int)div.reserved_size, (int)dlen/1000);
10611030
#endif
10621031

10631032
if (!DIV_connect_with_base(&tdsinfo, &div)){
10641033
error = 1;
10651034
}
10661035

10671036
#ifdef DEBUG
1068-
fprintf(stderr, "after connect: tdsinfo->num_chunks = %i, tdsinfo->bytelen = %i\n", (int)tdsinfo.num_chunks, (int)tdsinfo.tdslen);
1037+
fprintf(stderr, "after connect: tdsinfo->num_chunks = %i, tdsinfo->bytelen = %i KiB\n", (int)tdsinfo.num_chunks, (int)tdsinfo.tdslen/1000);
10691038
#endif
10701039

10711040
// destroy members, but keep memory

0 commit comments

Comments
 (0)