Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Add an additional 'Confirm ETH/XDAI wrap' modal when wrap MAX qty #1185

Open
elena-zh opened this issue Aug 5, 2021 · 0 comments
Open

Add an additional 'Confirm ETH/XDAI wrap' modal when wrap MAX qty #1185

elena-zh opened this issue Aug 5, 2021 · 0 comments
Labels
app:CowSwap CowSwap app Enhancement New feature or request Medium Severity indicator. It causes some undesirable behavior, but the system is still functional

Comments

@elena-zh
Copy link

elena-zh commented Aug 5, 2021

It would be nice to add an additional 'Confirm ETH/XDAI wrap' modal when wrap MAX qty of ETH/XDAI token using SWAP from.
To reproduce:

  1. Select max ETH token value in the From field
  2. Select WETH token in the To field
  3. Press on the Wrap button

AR: request to confirm the transaction is sent to the connected wallet
add an additional warning.jpg

ER: add an additional warning like it is implemented for 'Wrap your ETH first or switch to WETH9!' flow
image.png
@elena-zh elena-zh added app:CowSwap CowSwap app Enhancement New feature or request Medium Severity indicator. It causes some undesirable behavior, but the system is still functional labels Aug 5, 2021
@anxolin anxolin mentioned this issue Apr 2, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
app:CowSwap CowSwap app Enhancement New feature or request Medium Severity indicator. It causes some undesirable behavior, but the system is still functional
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elena-zh