Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New install script doesn't work correctly on Ubuntu #491

Closed
alexwhitman opened this issue Sep 18, 2016 · 10 comments
Closed

New install script doesn't work correctly on Ubuntu #491

alexwhitman opened this issue Sep 18, 2016 · 10 comments

Comments

@alexwhitman
Copy link
Contributor

The new installer script added in #487 doesn't work correctly on Ubuntu.

Ubuntu uses dash for sh. dash doesn't support pushd and popd so the script should either use a POSIX compatible method or use bash explicitly.

The script leaves a bunch of .mo files in the root of the repository directory which are marked as untracked by git. They should either be cleaned up at the end of the script or added to .gitignore.

After the script runs (when changed to use bash), the root menu item in the top menu bar/panel says "Unknown Application Name" rather than "Terminix".
workspace 1_002

Ping @danielkza

@danielkza
Copy link
Contributor

My bad for not testing properly on Ubuntu, I'll fix it up tomorrow.

Em dom, 18 de set de 2016 03:46, Alex Whitman [email protected]
escreveu:

The new installer script added in #487
#487 doesn't work correctly on
Ubuntu.

Ubuntu uses dash for sh. dash doesn't support pushd and popd so the
script should either use a POSIX compatible method or use bash explicitly.

The script leaves a bunch of .mo files in the root of the repository
directory which are marked as untracked by git. They should either be
cleaned up at the end of the script or added to .gitignore.

After the script runs (when changed to use bash), the root menu item in
the top menu bar/panel says "Unknown Application Name" rather than
"Terminix".
[image: workspace 1_002]
https://cloud.githubusercontent.com/assets/422013/18613481/cf91f9bc-7d73-11e6-9039-1744e11eb8a9.png

Ping @danielkza https://github.com/danielkza


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#491, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtnTsT8BrLb3VPi74eouAVsj2WR7NL-ks5qrN5HgaJpZM4J_0fT
.

@danielkza
Copy link
Contributor

@alexwhitman Can you please try e7f3f04?

I noticed that Terminix won't run unless I have libsecret-1-dev installed, due to the executable linking to libsecret-1.so instead of the fully versioned library, but I don't believe this is caused by the installation script. Do you notice the same issue?

@gnunn1
Copy link
Owner

gnunn1 commented Sep 18, 2016

Btw libsecret should be an optional dependency, if terminix is not running without it being present open an issue for it and I'll have a look at it. Also if Ubuntu is using a different name then arch that would be good to fix as well.

@danielkza
Copy link
Contributor

This is what I get after compiling and installing (with the new script) in Ubuntu 16.04:

$ terminix
object.Exception@../.dub/packages/gtk-d-3.3.1/src/gtkc/Loader.d(123): Library load failed: libsecret-1.so

I just checked and Fedora does the same thing as Ubuntu: the devel package is the one that provides libsecret-1.so. The regular package only provides libsecret-1.so.0 and libsecret-1.so.0.0 , so it seems to me GtkD is doing the wrong thing.

@gnunn1
Copy link
Owner

gnunn1 commented Sep 18, 2016

This is me not GtkD since I created the wrapper API for it. It's referenced
in one of the files in source/secretc.

On 18 Sep 2016 10:28, "Daniel Miranda" [email protected] wrote:

This is what I get after compiling and installing (with the new script) in
Ubuntu 16.04:

$ terminix
object.Exception@../.dub/packages/gtk-d-3.3.1/src/gtkc/Loader.d(123): Library load failed: libsecret-1.so

I just checked and Fedora does the same thing as Ubuntu: the devel package
is the one that provides libsecret-1.so. The regular package only
provides libsecret-1.so.0 and libsecret-1.so.0.0 , so it seems to me GtkD
is doing the wrong thing.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#491 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI7LnkvhtKcC-u4Yq97w18IDQf9G6jEyks5qrUp7gaJpZM4J_0fT
.

@danielkza
Copy link
Contributor

Should be easier to fix then 😄

@gnunn1 gnunn1 closed this as completed in e7f3f04 Sep 18, 2016
gnunn1 added a commit that referenced this issue Sep 18, 2016
@gnunn1
Copy link
Owner

gnunn1 commented Sep 18, 2016

I've fixed the issues with libsecret so hopefully all is good now, if not add an issue and I'll look at it further.

@alexwhitman
Copy link
Contributor Author

The installer script now works (i.e. doesn't error) but the root menu item still says "Unknown Application Name".
workspace 1_002

@danielkza
Copy link
Contributor

That's weird, it doesn't do that for me on 16.04. The installer should be
placing the exact same files it was before. Do you have any error messages
in the session logs?

Em seg, 19 de set de 2016 05:03, Alex Whitman [email protected]
escreveu:

The installer script now works (i.e. doesn't error) but the root menu item
still says "Unknown Application Name".
[image: workspace 1_002]
https://cloud.githubusercontent.com/assets/422013/18625656/e550c9a2-7e47-11e6-9562-102a950b7358.png


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#491 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAtnTstT8o3oN-3-eJfsQXp90e6CCdObks5qrkHSgaJpZM4J_0fT
.

@alexwhitman
Copy link
Contributor Author

Rebooted my computer for other reasons and now it's working fine. Searching for "Unknown Application Name" on Google suggests that a log out/in can fix it. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants