Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal title truncation on maximise/fullscreen #551

Closed
alexwhitman opened this issue Nov 2, 2016 · 14 comments
Closed

Terminal title truncation on maximise/fullscreen #551

alexwhitman opened this issue Nov 2, 2016 · 14 comments

Comments

@alexwhitman
Copy link
Contributor

I've set my terminal title to [${columns}x${rows}] ${title}. If I open a terminix window and then maximise the title is truncated at the start and appears as ...x76] alex@machine: ~. Triggering a title redraw, such as entering a line in the terminal, fixes the title.

I can also reproduce with just ${columns} as the title.

@gnunn1
Copy link
Owner

gnunn1 commented Nov 2, 2016

I can't reproduce this behavior in either Arch or Ubuntu 16.04. I tried reproducing it by splitting the terminal and switching to a long directory so the '...' ellipsis appears at the beginning. I then maximize the terminal and the title adjusts fine for the extra space and the ellipsis disappears. I also tried fullscreen and that worked fine as well.

Are there any non-default options you might have set that would be relevant to the behavior?

@alexwhitman
Copy link
Contributor Author

I've got some settings as non-default but I've played around with them and so far nothing has changed. I've also changed system fonts and sizes but that doesn't fix it either.

@gnunn1
Copy link
Owner

gnunn1 commented Nov 3, 2016

If you want to try something, you can add the following lines to terminal.d:370

lblTitle.setHexpand(true);
lblTitle.setHalign(Align.FILL);

@alexwhitman
Copy link
Contributor Author

That just centered the button in the terminal title bar, but the truncation still occurs.

@gnunn1
Copy link
Owner

gnunn1 commented Feb 17, 2017

@alexwhitman Are you still experiencing this issue?

@gnunn1
Copy link
Owner

gnunn1 commented Feb 18, 2017

@alexwhitman Can you let me know when you get a chance if the fix I checked in for #779 takes care of this as well.

@alexwhitman
Copy link
Contributor Author

@gnunn1 I've been out of the country for a bit but I'll check this in the next few days.

@alexwhitman
Copy link
Contributor Author

@gnunn1 I've had a chance to test and the same issue is present.

@gnunn1
Copy link
Owner

gnunn1 commented Feb 20, 2017

Bummer, when you say maximize I assume you mean the window and not the terminal? I'll try adding an event to window state change and doing the queueRedraw trick I'm using in the other bug report.

@alexwhitman
Copy link
Contributor Author

Yes, maximising the window. I can make a video if it helps.

@gnunn1
Copy link
Owner

gnunn1 commented Feb 20, 2017

No need, that should be fine.

@gnunn1
Copy link
Owner

gnunn1 commented Feb 21, 2017

I'm still thinking about this, the issue is the state change message happens in the window but I need to do the queueResize on a very specific widget in the terminal. Just trying to think of the best way while maintaining limited terminal visibility to the window.

@gnunn1
Copy link
Owner

gnunn1 commented Feb 23, 2017

So I've finally been able to reproduce this in 16.04 however it works fine in 16.10. As far as I can tell, this is a GTK bug. I could workaround it but it would involve some messiness to propagate the wondow state change down to the control. Since this bug appears to be rectified in 16.10 I'm going to mark this as Won't Fix.

@alexwhitman
Copy link
Contributor Author

That's fair, it's only a really minor thing anyway which disappears once anything else is done with the window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants