Changed all binary command opcode values to hexadecimal.

We intermixed hexidecimal and base 10 values throughout the code
for any given binary operation. This commit changes all the base
10 values to hexadecimal. This way the opcode definitions match
up better with the code in the memcached project.

Change-Id: Ida6d144411c5c9257358a92fb2eaadc2527a94f7
Reviewed-on: http://review.couchbase.org/6950
Tested-by: Michael Wiederhold <[email protected]>
Reviewed-by: Matt Ingenthron <[email protected]>

Author: Mike Wiederhold

src/main/java/net/spy/memcached/protocol/binary/DeleteOperationImpl.java

@@ -10,7 +10,7 @@
 class DeleteOperationImpl extends OperationImpl implements
 		DeleteOperation {
 
-	private static final int CMD=4;
+	private static final int CMD=0x04;
 
 	private final String key;
 	private final long cas;

src/main/java/net/spy/memcached/protocol/binary/FlushOperationImpl.java

@@ -5,7 +5,7 @@
 
 class FlushOperationImpl extends OperationImpl implements FlushOperation {
 
-	private static final int CMD=8;
+	private static final int CMD=0x08;
 	private final int delay;
 
 	public FlushOperationImpl(OperationCallback cb) {

src/main/java/net/spy/memcached/protocol/binary/GetOperationImpl.java

@@ -14,7 +14,7 @@ class GetOperationImpl extends OperationImpl
 	implements GetOperation, GetsOperation, GetlOperation,
 	GetAndTouchOperation {
 
-	static final int GET_CMD=0;
+	static final int GET_CMD=0x00;
 	static final int GETL_CMD=0x94;
 	static final int GAT_CMD=0x1d;
 

src/main/java/net/spy/memcached/protocol/binary/MultiGetOperationImpl.java

@@ -16,7 +16,7 @@
 
 class MultiGetOperationImpl extends OperationImpl implements GetOperation {
 
-	private static final int CMD_GETQ=9;
+	private static final int CMD_GETQ=0x09;
 
 	private final Map<Integer, String> keys=new HashMap<Integer, String>();
 	private final Map<Integer, byte[]> bkeys=new HashMap<Integer, byte[]>();

src/main/java/net/spy/memcached/protocol/binary/MutatorOperationImpl.java

@@ -11,8 +11,8 @@
 class MutatorOperationImpl extends OperationImpl implements
 		MutatorOperation {
 
-	private static final int CMD_INCR=5;
-	private static final int CMD_DECR=6;
+	private static final int CMD_INCR=0x05;
+	private static final int CMD_DECR=0x06;
 
 	private final Mutator mutator;
 	private final String key;

src/main/java/net/spy/memcached/protocol/binary/NoopOperationImpl.java

@@ -8,7 +8,7 @@
  */
 class NoopOperationImpl extends OperationImpl implements NoopOperation {
 
-	static final int CMD=10;
+	static final int CMD=0x0a;
 
 	public NoopOperationImpl(OperationCallback cb) {
 		super(CMD, generateOpaque(), cb);

src/main/java/net/spy/memcached/protocol/binary/OperationImpl.java

@@ -27,12 +27,12 @@ abstract class OperationImpl extends BaseOperationImpl implements Operation {
 	/**
 	 * Error code for items that were not found.
 	 */
-	protected static final int ERR_NOT_FOUND = 1;
-	protected static final int ERR_EXISTS = 2;
-	protected static final int ERR_EINVAL = 4;
-	protected static final int ERR_NOT_STORED = 5;
-	protected static final int ERR_NOT_MY_VBUCKET = 7;
-	protected static final int ERR_TEMP_FAIL = 134;
+	protected static final int ERR_NOT_FOUND = 0x01;
+	protected static final int ERR_EXISTS = 0x02;
+	protected static final int ERR_EINVAL = 0x04;
+	protected static final int ERR_NOT_STORED = 0x05;
+	protected static final int ERR_NOT_MY_VBUCKET = 0x07;
+	protected static final int ERR_TEMP_FAIL = 0x86;
 
 	protected static final OperationStatus NOT_FOUND_STATUS =
 		new CASOperationStatus(false, "Not Found", CASResponse.NOT_FOUND);

src/main/java/net/spy/memcached/protocol/binary/StoreOperationImpl.java

@@ -12,9 +12,9 @@
 class StoreOperationImpl extends OperationImpl
 	implements StoreOperation, CASOperation {
 
-	private static final int SET=1;
-	private static final int ADD=2;
-	private static final int REPLACE=3;
+	private static final int SET=0x01;
+	private static final int ADD=0x02;
+	private static final int REPLACE=0x03;
 
 	static final int SETQ=0x11;
 	static final int ADDQ=0x12;

src/main/java/net/spy/memcached/protocol/binary/TouchOperationImpl.java

@@ -13,7 +13,7 @@
 public class TouchOperationImpl extends OperationImpl
 	implements KeyedOperation {
 
-	static final int CMD=28;
+	static final int CMD=0x1c;
 
 	private final String key;
 	private final int exp;

src/main/java/net/spy/memcached/protocol/binary/VersionOperationImpl.java

@@ -6,7 +6,7 @@
 
 class VersionOperationImpl extends OperationImpl implements VersionOperation {
 
-	private static final int CMD = 11;
+	private static final int CMD = 0x0b;
 
 	public VersionOperationImpl(OperationCallback cb) {
 		super(CMD, generateOpaque(), cb);