SPY-47: Client object should have toString().

The toString() method in MemcachedClient now prints out it's
configuration eg. the information of the ConnectionFactory it
is using.

Change-Id: Ic8f3741bdcdc97d5bb46b2c4a68caec998903fde
Reviewed-on: http://review.couchbase.org/9473
Tested-by: Michael Wiederhold <[email protected]>
Reviewed-by: Michael Wiederhold <[email protected]>

Author: Mike Wiederhold

src/main/java/net/spy/memcached/MemcachedClient.java

@@ -128,6 +128,8 @@ public class MemcachedClient extends SpyThread
 
 	final AuthDescriptor authDescriptor;
 
+	private final ConnectionFactory connFactory;
+
 	private final AuthThreadMonitor authMonitor = new AuthThreadMonitor();
 	private volatile boolean reconfiguring = false;
 	private ConfigurationProvider configurationProvider;
@@ -176,6 +178,7 @@ public MemcachedClient(ConnectionFactory cf, List<InetSocketAddress> addrs)
 			throw new IllegalArgumentException(
 				"Operation timeout must be positive.");
 		}
+		connFactory = cf;
 		tcService = new TranscodeService(cf.isDaemon());
 		transcoder=cf.getDefaultTranscoder();
 		opFact=cf.getOperationFactory();
@@ -281,10 +284,10 @@ public MemcachedClient(ConnectionFactory cf, final List<URI> baseList,
 			cfb.setAuthDescriptor(ad);
 		}
 
-		cf = cfb.build();
+		connFactory = cfb.build();
 
 		List<InetSocketAddress> addrs = AddrUtil.getAddresses(bucket.getConfig().getServers());
-		if(cf == null) {
+		if(connFactory == null) {
 			throw new NullPointerException("Connection factory required");
 		}
 		if(addrs == null) {
@@ -294,23 +297,23 @@ public MemcachedClient(ConnectionFactory cf, final List<URI> baseList,
 			throw new IllegalArgumentException(
 			"You must have at least one server to connect to");
 		}
-		if(cf.getOperationTimeout() <= 0) {
+		if(connFactory.getOperationTimeout() <= 0) {
 			throw new IllegalArgumentException(
 				"Operation timeout must be positive.");
 		}
-		tcService = new TranscodeService(cf.isDaemon());
-		transcoder=cf.getDefaultTranscoder();
-		opFact=cf.getOperationFactory();
+		tcService = new TranscodeService(connFactory.isDaemon());
+		transcoder=connFactory.getDefaultTranscoder();
+		opFact=connFactory.getOperationFactory();
 		assert opFact != null : "Connection factory failed to make op factory";
-		conn=cf.createConnection(addrs);
+		conn=connFactory.createConnection(addrs);
 		assert conn != null : "Connection factory failed to make a connection";
-		operationTimeout = cf.getOperationTimeout();
-		authDescriptor = cf.getAuthDescriptor();
+		operationTimeout = connFactory.getOperationTimeout();
+		authDescriptor = connFactory.getAuthDescriptor();
 		if(authDescriptor != null) {
 			addObserver(this);
 		}
 		setName("Memcached IO over " + conn);
-		setDaemon(cf.isDaemon());
+		setDaemon(connFactory.isDaemon());
 		this.configurationProvider.subscribe(bucketName, this);
 		start();
 	}
@@ -2178,4 +2181,8 @@ public void connectionLost(SocketAddress sa) {
 		// Don't care.
 	}
 
+	@Override
+	public String toString() {
+		return connFactory.toString();
+	}
 }